helm-controller
helm-controller copied to clipboard
allow dependsOn to match on HelmRelease labels
the current dependsOn
implementation requires HelmRelease
object names. A very useful and modular solution would be to allow passing a label matcher to find the requested array of HelmRelease
objects to depend on:
https://github.com/fluxcd/helm-controller/blob/2195310e7c2cdeb201b4b99d4655d2b62800f6f1/controllers/helmrelease_controller.go#L451-L475
Using labels would break the dependsOn functionality. At cluster bootstrap, some HelmReleases may end up in etcd faster than others. Without knowing a dependency name, Flux can't wait for the creation and will just go head and install the charts in the wrong order.
Thanks, that's a good point, if the HR element does not exist, the dependency "looks" valid.