flux2 icon indicating copy to clipboard operation
flux2 copied to clipboard

`flux push artifact --ignore-paths` should be added on top of the defaults

Open matheuscscp opened this issue 11 months ago • 2 comments

Describe the bug

The default ignore paths are very useful for most cases:

https://github.com/fluxcd/flux2/blob/0cc68e0521dfcee719aad5866aff6c10e0eb45c6/cmd/flux/build_artifact.go#L56

.git/,.gitignore,.gitmodules,.gitattributes,*.jpg,*.jpeg,*.gif,*.png,*.wmv,*.flv,*.tar.gz,*.zip

I don't want to re-specify all of them when using the --ignore-paths, I want to add more ignore paths on top of them.

Not using these defaults must still be supported somehow, but adding paths on top of the defaults would be very useful.

Steps to reproduce

flux push artifact --ignore-paths=some/path ...

Expected behavior

I don't want to re-specify all of them when using the --ignore-paths, I want to add more ignore paths on top of them.

Screenshots and recordings

No response

OS / Distro

N/A

Flux version

v2.4.0

Flux check

N/A

Git provider

No response

Container Registry provider

No response

Additional context

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

matheuscscp avatar Jan 12 '25 23:01 matheuscscp

I think the current behavior is correct, because you need to be able to override/disable defaults, and the option allows that. It may be less convenient in certain cases, but it gives more flexibility.

artem-nefedov avatar Feb 07 '25 16:02 artem-nefedov

We could have a different flag that uses the defaults as well

matheuscscp avatar Feb 07 '25 17:02 matheuscscp