flux2 icon indicating copy to clipboard operation
flux2 copied to clipboard

Maintain original scheme when using --token-auth

Open carlosonunez-vmw opened this issue 3 years ago • 1 comments

Fixes #3116.

If you're using an HTTP-based Git server with Flux, you need to provide --token-auth to avoid triggering an SSH host key check (see #2825). Unfortunately, doing this forces the URL in the GitRepository resource created during bootstrapping to always use https. This will cause Kustomization reconcile errors for servers that do not have HTTPS enabled or do not have the appropriate certs installed or available.

This pull request fixes this by keeping the repository URL scheme intact when using --token-auth.

Signed-off-by: Carlos Nunez [email protected]

carlosonunez-vmw avatar Sep 16 '22 22:09 carlosonunez-vmw

Thanks, @hiddeco! Good suggestion.

carlosonunez-vmw avatar Sep 20 '22 01:09 carlosonunez-vmw

@carlosonunez-vmw please squash the two commits

stefanprodan avatar Sep 22 '22 09:09 stefanprodan

done; @stefanprodan PTAL

carlosonunez-vmw avatar Sep 28 '22 03:09 carlosonunez-vmw

you're welcome!-- CarlosOn Sep 28, 2022, at 00:36, Stefan Prodan @.***> wrote: @stefanprodan approved this pull request.

LGTM Thanks @carlosonunez-vmw 🥇

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

carlosonunez-vmw avatar Oct 11 '22 06:10 carlosonunez-vmw