flux2 icon indicating copy to clipboard operation
flux2 copied to clipboard

Enable `RecoverPanic` option on reconcilers

Open hiddeco opened this issue 1 year ago • 3 comments

Controller-runtime has a setting which can be set on a reconciler to ensure it recovers from panics instead of making the whole controller crash. This should be enabled on all reconcilers to improve continuity, which is especially useful for e.g. source-controller where a restart often means an erase of the cache.

  • [ ] source-controller
  • [ ] kustomize-controller
  • [ ] helm-controller
  • [ ] notification-controller
  • [ ] image-reflector-controller
  • [x] image-automation-controller

hiddeco avatar Aug 02 '22 09:08 hiddeco

Hey @hiddeco can I work on this? Just to clarify, all the reconcilers in the above listed controllers(repos) need to be enabled with RecoverPanic option?

Santosh1176 avatar Aug 04 '22 21:08 Santosh1176

Just to clarify, all the reconcilers in the above listed controllers(repos) need to be enabled with RecoverPanic option?

Yes

stefanprodan avatar Aug 05 '22 09:08 stefanprodan

Please /assign

Santosh1176 avatar Aug 05 '22 10:08 Santosh1176

@Santosh1176 thanks for working through all controllers to get this implemented. :bow:

pjbgf avatar Aug 15 '22 08:08 pjbgf

@Santosh1176 thanks for working through all controllers to get this implemented. bow

Thank you!

Santosh1176 avatar Aug 15 '22 12:08 Santosh1176