flux2
flux2 copied to clipboard
Enable `RecoverPanic` option on reconcilers
Controller-runtime has a setting which can be set on a reconciler to ensure it recovers from panics instead of making the whole controller crash. This should be enabled on all reconcilers to improve continuity, which is especially useful for e.g. source-controller where a restart often means an erase of the cache.
- [ ] source-controller
- [ ] kustomize-controller
- [ ] helm-controller
- [ ] notification-controller
- [ ] image-reflector-controller
- [x] image-automation-controller
Hey @hiddeco can I work on this?
Just to clarify, all the reconcilers in the above listed controllers(repos) need to be enabled with RecoverPanic
option?
Just to clarify, all the reconcilers in the above listed controllers(repos) need to be enabled with RecoverPanic option?
Yes
Please /assign
@Santosh1176 thanks for working through all controllers to get this implemented. :bow:
@Santosh1176 thanks for working through all controllers to get this implemented. bow
Thank you!