fluxcd
add support for deploymentLabels
This PR adds support for configuring additional labels for the deployment using deploymentLabels in values.yaml.
@KrylixZA i'm investigating that. i'd say if that needs to be addressed, we shall do so in a different PR, since they're completely different things.
@aryan9600 README has been updated. Should I make a similar update to docs/gitbook/install/flagger-install-on-kubernetes.md?
Sure, that'd be great. Could you also specify the podLabels and deploymentLabels values in the table in charts/flagger/README.md?
Sure, that'd be great. Could you also specify the
podLabelsanddeploymentLabelsvalues in the table incharts/flagger/README.md?
done
@aryan9600 @stefanprodan - Just following up on this PR. Are any other changes needed? Thanks for taking the time to review!
@aryan9600 - How do I trigger a build? It looks like one is needed before the PR can be merged.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.30%. Comparing base (
febc327) to head (03d4acc). Report is 24 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1707 +/- ##
==========================================
+ Coverage 39.27% 39.30% +0.03%
==========================================
Files 284 284
Lines 22379 22391 +12
==========================================
+ Hits 8789 8801 +12
Misses 12643 12643
Partials 947 947
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@aryan9600 Is there anything else that I need to do before build-flagger action can be executed?