flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Allow passing of metrics server secret to flagger

Open joedborg opened this issue 1 year ago • 3 comments

An attempt at fixing https://github.com/fluxcd/flagger/issues/1671. I'm not much of a Go wizard, so it probably requires some cleanup.

This adds the ability to add --metrics-server-secret-ref to give the ability to auth against external Prometheus endpoints.

joedborg avatar Jun 28 '24 16:06 joedborg

@stefanprodan and chance I can get a review on this please?

joedborg avatar Aug 12 '24 15:08 joedborg

is it not possible to define custom MetricTemplate objects pointing to the prom server with the appropriate credentials? the query can be copy pasted from flagger's codebase. that's hardcoded anyway: https://github.com/fluxcd/flagger/blob/main/pkg/metrics/observers/istio.go#L27

aryan9600 avatar Oct 06 '24 18:10 aryan9600

@aryan9600 that's what I'm doing as a work around but I'd like the built ins to work as described without having to duplicate code from the repo to get it to work.

joedborg avatar Oct 11 '24 15:10 joedborg