flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Published 20 hours ago • verified publisher icon fluxcd

(bugfix) Issue-1464 issue resolved

Open S-mishina opened this issue 9 months ago • 4 comments

summary

if delegation: true is set while a VirtualService has already been created by Flagger, there are no changes to the newSpec. Therefore, I suspect that the hosts and gateway are not removed.

https://github.com/fluxcd/flagger/blob/9a0c6e7e54e3e822f9b505f3fb404bec77aeae55/pkg/router/istio.go#L296-L300

https://github.com/fluxcd/flagger/blob/9a0c6e7e54e3e822f9b505f3fb404bec77aeae55/pkg/router/istio.go#L333

[MEMO] Code of the relevant part https://github.com/fluxcd/flagger/blob/9a0c6e7e54e3e822f9b505f3fb404bec77aeae55/pkg/router/istio.go#L325-L364

※ This is just a suggestion for now, and there may be a better way to do it.

reference) https://github.com/fluxcd/flagger/issues/1464

S-mishina avatar May 15 '24 17:05 S-mishina