flagger
flagger copied to clipboard
Progress deadline exceeded not triggering a rollback during promotion
Describe the bug
A canary that is almost completed and is copying the template spec to primary. The primary then exceeds its progress deadline as one of the pods isn't ready and a continual loop of exceeded its progress deadline
logs are observed in Flagger, with seemingly no deadline.
The status of the canary at this point is similar to:
Status:
Canary Weight: 0
Conditions:
Message: Canary analysis completed, starting primary rolling update.
Reason: Promoting
Status: Unknown
Type: Promoted
Failed Checks: 0
Iterations: 0
Phase: Promoting
To Reproduce
At the point that copying the template spec to primary is happening prevent one of the pods from starting correctly, this is likely to be easier if there is a number of pods.
Expected behavior
After progress deadline is exceeded I would expect a rollback to occur.
Additional context
Flagger version: 1.35.0 Kubernetes version: 1.25.16 Service Mesh provider: Istio Ingress provider: Istio