flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Support for an update to HPA replicas resulting in a canary deployment

Open frankjkelly opened this issue 2 years ago • 1 comments

Describe the feature

What problem are you trying to solve?

  • We are using Flagger for canary deployments.
  • We tried to update the min replicas of an existing deployment but when Flux deployed the change only updated the canary HPA and did not initiate a canary deploy via flagger. We had to make a slight adjust to the deployment like this https://github.com/fluxcd/flagger/blob/main/docs/gitbook/faq.md#how-to-retry-a-failed-release to initiate flagger making a canary deployment and at which point it copied the HPA over canary was deemed successful.

Proposed solution

Flagger could monitor not just the K8S deployment but associated HPA configuration (if any)

Any alternatives you've considered?

Is there another way to solve this problem that isn't as good a solution? Great question - not sure.

frankjkelly avatar Dec 06 '23 17:12 frankjkelly

@stefanprodan @aryan9600 If you have time do you mind reviewing the above feature request and let me know if you think it is a reasonable ask or if you known of any alternatives. Thanks!

frankjkelly avatar Jan 10 '24 14:01 frankjkelly