flagger icon indicating copy to clipboard operation
flagger copied to clipboard

New Rollout hook "failure counter"

Open wispum opened this issue 2 years ago • 0 comments

Describe the feature

Most of our services have no steady incoming traffic flow, but more of an eventual traffic spikes, so we want to pause canary for "canary step interval" and retry again metrics checking. We know that flagger has ability to do it by "rollout hook" but there is no ability to skip increasing failure counter.

Proposed solution

For such purpose we want to add parameter into webhook (only for "rollout hook" if it's possible) - failureCounter. If this parameter is defined we skip increasing "total canary failure counter" (treshold) and increase only new one. If this failureCounter will be reached then whole canary will be stopped (or another phase, it can be discussed too). This failure counter will be optional and won't impact on default behaviour. We want to develop this feature by ourselves and contribute to your project.

wispum avatar Aug 31 '23 12:08 wispum