flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Support for ambassador ingress

Open jdamata opened this issue 5 years ago • 10 comments

I think all that is needed is to have ambassador annotations added to the primary service which would direct traffic to both the primary service and canary service based on weight.

https://www.getambassador.io/docs/dev-guide/canary-release-concepts/#flexible-kubernetes-canary-releases-smart-routing-with-ambassador

Ref: https://github.com/weaveworks/flagger/issues/67 https://github.com/weaveworks/flagger/issues/49

jdamata avatar Apr 10 '19 21:04 jdamata

Does Ambassador have a go client and CRD?

stefanprodan avatar Apr 11 '19 11:04 stefanprodan

Nope, theres talk of it in https://github.com/datawire/ambassador/issues/482.

jdamata avatar Apr 11 '19 15:04 jdamata

So thinking about this in a different way, if you have ambassador in front of istio, serving as the API Manager and cluster ingress, the service definition is separate and behind that (no standard ingress controller/gateway and ingress resources). If you did a canary deployment against the service definition, it seems like that would work. You wouldn't need to touch ambassador if you didn't use it for canary definition and just used flagger as that tool to manage istio.

cdbyrd avatar May 23 '19 13:05 cdbyrd

Hi, Here's an update about ambassador which now have both CRD (datawire/ambassador#482) and and client go.

trash-anger avatar Aug 05 '19 22:08 trash-anger

@stefanprodan can we remove the upstream-blocked label? also, is there a recommendation on how to use flagger to orchestrate canary while having Ambassador as the api-gateway?

RTodorov avatar Aug 15 '19 12:08 RTodorov

@RTodorov can you point me to the go clientset package?

stefanprodan avatar Aug 15 '19 16:08 stefanprodan

@RTodorov Is this something you are looking for? https://github.com/datawire/ambassador/tree/master/go

ghost avatar Aug 19 '19 14:08 ghost

any progress on supporting Flagger with Ambassador?

jonathanmccracken avatar Apr 28 '20 20:04 jonathanmccracken

I would also be very interested in this

olemarkus avatar Mar 25 '21 14:03 olemarkus

Hey there, is there any update on this?

klemmster avatar Feb 24 '23 17:02 klemmster