flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Add appdynamicscloud metric provider

Open charleslin-appd opened this issue 3 years ago • 3 comments

AppDynamics Cloud offers full-stack observability for large, managed Kubernetes deployments. I would like to use its metrics in flagger.

charleslin-appd avatar Feb 05 '23 23:02 charleslin-appd

Hi @stefanprodan, I think the PR is ready for review. Please let me know if I can provide anything else. I would love to get this into the next release.

Thank you,

Charles

charleslin-appd avatar Feb 07 '23 18:02 charleslin-appd

I believe the DCO check is passed. Any chance for getting the PR reviewed?

charleslin-appd avatar Feb 14 '23 23:02 charleslin-appd

Codecov Report

Base: 54.37% // Head: 54.23% // Decreases project coverage by -0.14% :warning:

Coverage data is based on head (134f92e) compared to base (05d08d3). Patch coverage: 39.02% of modified lines in pull request are covered.

:exclamation: Current head 134f92e differs from pull request most recent head 2608dc6. Consider uploading reports for the commit 2608dc6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
- Coverage   54.37%   54.23%   -0.14%     
==========================================
  Files          84       85       +1     
  Lines       10044    10172     +128     
==========================================
+ Hits         5461     5517      +56     
- Misses       3927     3983      +56     
- Partials      656      672      +16     
Impacted Files Coverage Δ
pkg/metrics/providers/factory.go 0.00% <0.00%> (ø)
pkg/metrics/providers/appdynamicscloud.go 39.66% <39.66%> (ø)
pkg/router/istio.go 76.98% <0.00%> (+0.09%) :arrow_up:
pkg/controller/scheduler_metrics.go 37.64% <0.00%> (+0.74%) :arrow_up:
pkg/metrics/observers/render.go 62.50% <0.00%> (+18.75%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Feb 19 '23 16:02 codecov-commenter