flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Manual gate control by api in loadtester

Open PalanQu opened this issue 2 years ago • 2 comments

Describe the feature

Manual approve each step of canary phase by send http request, for the current time, the loadtester accept the canary name and namespace as key, maybe we should add CanaryPhase in this key and auto remove the previous step key

canaryName := fmt.Sprintf("%s.%s", canary.Name, canary.Namespace)
approved := gate.isOpen(canaryName)

Proposed solution

Any alternatives you've considered?

Is there another way to solve this problem that isn't as good a solution?

PalanQu avatar Nov 04 '22 03:11 PalanQu

If accept this solution, I will create a PR for this

PalanQu avatar Nov 04 '22 03:11 PalanQu

I have proposed another way https://github.com/fluxcd/flagger/issues/1344 @PalanQu please take a look and see if we can do together?

teochenglim avatar Jan 13 '23 05:01 teochenglim