Add dedicated phase waiting traffic increase

[andylibrian]

This is to fix #1248 where canary is restarted to "Starting canary analysis" on confirm traffic increase failure.

Signed-off-by: Andy Librian [email protected]

[codecov-commenter]

Codecov Report

Merging #1252 (eb276db) into main (e65dfbb) will decrease coverage by 0.04%. The diff coverage is 32.00%.

@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
- Coverage   54.74%   54.69%   -0.05%     
==========================================
  Files          81       81              
  Lines        6949     6966      +17     
==========================================
+ Hits         3804     3810       +6     
- Misses       2550     2561      +11     
  Partials      595      595              

Impacted Files	Coverage Δ
pkg/canary/status.go	46.83% <0.00%> (-0.91%)	:arrow_down:
pkg/controller/scheduler_hooks.go	7.31% <0.00%> (-0.80%)	:arrow_down:
pkg/controller/scheduler.go	46.48% <88.88%> (+0.61%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[andylibrian]

Thanks for the review so far, I signed off my first commit. Then in the review I committed the suggested change through GitHub, and it turned out it's missing the signed-off-by. I will add the missing signed-off-by message and rebase this after the review is completed because it requires force push and it would restart the review. If you think otherwise, please let me know.

[aryan9600]

That's not an issue, please rebase and force push.

[andylibrian]

Hi @aryan9600, I have rebased and force push this branch as suggested. Do you have any more comment / feedback?

[aryan9600]

I'm currently testing this with various Canary objects, to make sure that adding this new phase doesn't break any existing functionality. If you want, you can do some testing as well, to make sure no bugs creep in inadvertently, thanks.