flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Labels in service is not replaced in version 1.22.0

Open andreilocks opened this issue 3 years ago • 1 comments

Describe the bug

I update the flagger version to use with keda, but it didn't behave as expected, service labels and selector kept pointing to the wrong version, not the promoted primary version.

In the log also presented several errors, which did not find the canary.

image

Service selector in version 1.21 after promote selector: app: api-procuradoria-primary

Service selector in version 1.22 after promote selector: app: api-procuradoria environment: test product: procuradoria startup: procuradoria tier: api vertical: arrecadacao

To Reproduce

  • Update flagger from version 1.21 to 1.22.0
  • Deploy simple app with mesh provider kubernetes
  • After promoting the service labels are still pointed to the wrong version.
  • If the app has hpa, it will show print errors.

Expected behavior

After promote, flagger need change the labels and selector to version primary.

Additional context

  • Flagger version: 1.22.0
  • Kubernetes version: 1.22.9 (EKS)
  • Service Mesh provider: kubernetes
  • Ingress provider:

andreilocks avatar Jul 12 '22 13:07 andreilocks

I can't reproduce this, could you please provide your Canary definition and what your services look like (kubectl describe svc -n ) when using v1.21.0 and v1.22.0 respectively? Thanks :)

aryan9600 avatar Jul 13 '22 04:07 aryan9600