flagger icon indicating copy to clipboard operation
flagger copied to clipboard

Flagger canary promotion didn't honor for pod ready

Open cdlliuy opened this issue 3 years ago • 0 comments

Describe the feature

During promotion , flagger just copy the spec of deployment, and then start traffic routing & scale down canary But for some slow startup application, I noticed the primary didn't be ready at all when the canary is scaled down to 0 .. so, there is down time during the promotion..

Proposed solution

Suggest to check deployment status before continuing the further steps.

Any alternatives you've considered?

Adding a waitingfinizing webhook may help on this "https://github.com/fluxcd/flagger/issues/1193" with manual interruption.

cdlliuy avatar May 20 '22 07:05 cdlliuy