tofu-controller icon indicating copy to clipboard operation
tofu-controller copied to clipboard

Update makefile as it is failing to install required binaries for Go v1.18+

Open tomhuang12 opened this issue 3 years ago • 4 comments

go get no longer installs the binaries: https://go.dev/doc/go-get-install-deprecation.

I think we can add something so that it runs go get for v1.17 and lower and go install for v1.18+.

tomhuang12 avatar Sep 01 '22 22:09 tomhuang12

Is it worth having a build container that runs all the make targets? That way the versions are in control and not relying on other peoples systems.

nalum avatar Sep 06 '22 08:09 nalum

Hmm yeah that could be useful. However, if the user want to run commands not in a make target, they would run into a similar issue if version mismatch. I think this is the only obstacle I see people are facing when getting started to contribute? I could simply change go get to go install since GO 1.16 already supports go install.

tomhuang12 avatar Sep 09 '22 20:09 tomhuang12

@Nalum running make targets in a container might break CI/CD flows to require Docker service in build servers (and even a bigger issue when the CI runners run as container themselves)

bivas avatar Sep 13 '22 17:09 bivas

We could set it up in such a way that that wouldn't be the case. But just a thought and I can see it over complicating things

nalum avatar Sep 14 '22 08:09 nalum

Closing due to age and lack of action.

lasomethingsomething avatar Nov 02 '23 13:11 lasomethingsomething