tofu-controller icon indicating copy to clipboard operation
tofu-controller copied to clipboard

Published 20 hours ago • verified publisher icon flux-iac

Option for Pull Request on plan

Open steveww opened this issue 3 years ago • 4 comments

Currently when not using auto the plan commit is show in the status. This plan commit must then be put into the manifest and pushed. This workflow could be greatly improved if the tf-controller could create a pull request with this change against the management repo. In a similar way to how Flux image automation works.

steveww avatar Apr 25 '22 10:04 steveww

Thank you for the feature idea, @steveww.

chanwit avatar Apr 25 '22 12:04 chanwit

@phoban01 @tomhuang12 it would be great to start a discussion here around Git providers / PR integrations, please.

chanwit avatar Apr 25 '22 12:04 chanwit

We can reuse a lot of the code from image automation controller for committing and pushing: https://github.com/fluxcd/image-automation-controller/blob/cd9eaffefc3072df552790e8e1649762e0ef9922/controllers/imageupdateautomation_controller.go#L368-L392

tomhuang12 avatar Apr 27 '22 17:04 tomhuang12

Rather than double up on the code, how about the image automation controller exposing the PR functionality as an API? Careful consideration of security is essential.

steveww avatar Apr 28 '22 09:04 steveww