flux-sched icon indicating copy to clipboard operation
flux-sched copied to clipboard

[WIP] Add support for expiration update

Open milroy opened this issue 10 months ago • 1 comments

This PR adds functionality to update an allocated job's expiration. To do so, we add modify functionality within the traverser to update a jobid rather than remove it. The PR adds functionality to update planner scheduled points to extend the last and last_p->at times. When merged, this PR will resolve issue #1079.

This PR is WIP as it isn't clear whether the simple modification of an allocation's expiration will work when there are queue policies that create reservations.

milroy avatar Mar 27 '24 01:03 milroy

Codecov Report

Merging #1158 (f15a5f0) into master (68c636a) will decrease coverage by 1.0%. The diff coverage is 31.7%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1158     +/-   ##
========================================
- Coverage    71.0%   70.1%   -1.0%     
========================================
  Files          96      96             
  Lines       12867   13079    +212     
========================================
+ Hits         9147    9175     +28     
- Misses       3720    3904    +184     
Files Coverage Δ
resource/traversers/dfu_impl.hpp 94.7% <ø> (ø)
resource/planner/c++/planner.cpp 81.9% <0.0%> (-1.6%) :arrow_down:
resource/traversers/dfu.cpp 83.4% <0.0%> (-4.2%) :arrow_down:
qmanager/modules/qmanager.cpp 70.6% <70.4%> (-2.9%) :arrow_down:
resource/planner/c/planner_multi_c_interface.cpp 55.3% <0.0%> (-2.8%) :arrow_down:
resource/planner/c/planner_c_interface.cpp 66.8% <0.0%> (-3.3%) :arrow_down:
resource/utilities/command.cpp 71.6% <0.0%> (-3.8%) :arrow_down:
resource/modules/resource_match.cpp 66.8% <17.3%> (-1.8%) :arrow_down:
resource/traversers/dfu_impl_update.cpp 70.0% <43.9%> (-7.7%) :arrow_down:

codecov[bot] avatar Mar 30 '24 08:03 codecov[bot]