Vscode setup

[trws]

New setup for vscode and similar. The commits and messages provide much more detail, but this builds on the devcontainer setup so we get a pretty full featured semi-IDE with all of flux's paths and idioms working and correctly identifying things.

If and when we get the python linting PR in, it would be good to refactor a bit of this, like to have the dockerfile use the requirements from the top level, and to better integrate the settings that has for flake8 and mypy (they are on in here but not well configured since I didn't want to duplicate all that good work).

[trws]

Bah, forgot to run my rebase before pushing. Should be cleaned up.

[vsoch]

If there is a dependency here on the pre-commit stuff - can we review / merge that first and update here, and then save the double PR? @grondo are you still busy with top secret duties? :secret: :ninja:

[garlick]

Is this just waiting to have the conflicts resolved? @grondo already approved and I think the aforementioned pre-commit stuff was merged.

[vsoch]

I'd like to give this a spin too (after rebase). @trws what is missing for me is a brief description (in the developer docs somewhere maybe?) about how to use this environment, what you've added, etc. Right now not knowing I'd be afraid to just open it up in case it's going to compile something on my local machine without asking!

[trws]

Rebased and tweaked the readme to add some more information. It doesn't build anything, but it does install some extra packages that are generally useful as well as the extensions I pre-configured to give semantic completion for everything.

[vsoch]

Okay here are the recommended I see:

It gave me the option to install them, so as long as I'm not developing anything locally my preference is to say no, so I'm okay with this setup. Just curious - why should we have a local setup when we have the devcontainer?

I can give more feedback as I use it in the future, but I don't see any alarming issues.

[trws]

It's mainly a preference thing, if someone wants to say use the remote extension to develop on one of the clusters, which is already set up as a dev environment, then it will use the local setup and you can install or not install the plugins you want. Also potentially good for using debugging features, since it's likely we'll end up needing to debug outside of the devcontainer at least sometimes.

[codecov[bot]]

Codecov Report

Merging #4683 (9edb414) into master (84613c5) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 9edb414 differs from pull request most recent head 8528f63. Consider uploading reports for the commit 8528f63 to get more accurate results

@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
- Coverage   83.42%   83.41%   -0.02%     
==========================================
  Files         414      414              
  Lines       70012    70011       -1     
==========================================
- Hits        58407    58398       -9     
- Misses      11605    11613       +8     

Impacted Files	Coverage Δ
src/modules/job-list/stats.c	69.03% <0.00%> (-4.69%)	:arrow_down:
src/modules/job-info/guest_watch.c	76.21% <0.00%> (-1.36%)	:arrow_down:
src/modules/job-archive/job-archive.c	62.62% <0.00%> (-0.70%)	:arrow_down:
src/broker/overlay.c	85.68% <0.00%> (-0.31%)	:arrow_down:
src/cmd/flux-mini.py	92.57% <0.00%> (-0.24%)	:arrow_down:
src/cmd/flux-jobs.py	95.56% <0.00%> (ø)
src/bindings/python/flux/job/stats.py	97.22% <0.00%> (ø)
src/common/libsdprocess/sdprocess.c	69.13% <0.00%> (+0.12%)	:arrow_up:
src/modules/cron/cron.c	82.92% <0.00%> (+0.44%)	:arrow_up:
src/broker/state_machine.c	82.74% <0.00%> (+0.58%)	:arrow_up:
... and 3 more

[trws]

Just realized this is still pending, did a rebase to bring this up to date, cleaned up the one conflict. Hopefully this will pass through now.

[codecov[bot]]

Codecov Report

Merging #4683 (2118439) into master (9734f4f) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
+ Coverage   83.45%   83.46%   +0.01%     
==========================================
  Files         414      414              
  Lines       70049    70049              
==========================================
+ Hits        58458    58468      +10     
+ Misses      11591    11581      -10     

Impacted Files	Coverage Δ
src/common/libsubprocess/local.c	84.05% <0.00%> (-0.49%)	:arrow_down:
src/modules/job-info/guest_watch.c	76.75% <0.00%> (+0.54%)	:arrow_up:
src/modules/job-list/list.c	79.12% <0.00%> (+0.54%)	:arrow_up:
src/broker/state_machine.c	82.74% <0.00%> (+0.58%)	:arrow_up:
src/common/libsdprocess/sdprocess.c	69.76% <0.00%> (+0.62%)	:arrow_up: