plus_plugins icon indicating copy to clipboard operation
plus_plugins copied to clipboard

[Question]: Why did you removed `productName` from `WindowsDeviceInfo` ?

Open gehad-ahmed-mohammed opened this issue 3 years ago • 1 comments

What is your question?

You removed almost all WindowsDeviceInfo .. why did you do this ?

gehad-ahmed-mohammed avatar Aug 15 '22 09:08 gehad-ahmed-mohammed

Hey!

It was me who added all the necessary information for Windows in https://github.com/fluttercommunity/plus_plugins/pull/814 including the productName.

It got reverted because of not incrementing the versions semantically.

Some Flutter engineers got confused by it at #1000. Instead of actually trying to increment the version of device_info_plus in pubspec.yaml of their app, they tried editing package's internal code or forcing dependency overrides. I'm speechless about this level of intelligence.

At the moment you have two choices:

  1. Force pin device_info_plus version to 4.0.2 in your pubspec.yaml file.
dependencies:
  device_info_plus: 4.0.2
  1. Use package from my fork.
dependencies:
  device_info_plus:
    git:
      url: https://github.com/alexmercerind/plus_plugins.git
      path: packages/device_info_plus/device_info_plus
      ref: main

dependency_overrides:
  device_info_plus_platform_interface:
    git:
      url: https://github.com/alexmercerind/device_info_plus.git
      path: packages/device_info_plus/device_info_plus_platform_interface
      ref: main
  device_info_plus_windows:
    git:
      url: https://github.com/alexmercerind/device_info_plus.git
      path: packages/device_info_plus/device_info_plus_windows
      ref: main
  device_info_plus_linux:
    git:
      url: https://github.com/alexmercerind/device_info_plus.git
      path: packages/device_info_plus/device_info_plus_linux
      ref: main
  device_info_plus_macos:
    git:
      url: https://github.com/alexmercerind/device_info_plus.git
      path: packages/device_info_plus/device_info_plus_macos
      ref: main

alexmercerind avatar Aug 15 '22 12:08 alexmercerind