plus_plugins icon indicating copy to clipboard operation
plus_plugins copied to clipboard

Published 20 hours ago • verified publisher icon fluttercommunity

Remove androidId

Open nohli opened this issue 2 years ago • 2 comments

Description

The method channel call for getting the androidId was removed in https://github.com/fluttercommunity/plus_plugins/pull/918, without removing the package's getter - it is misleading to have a getter that doesn't work and always returns null.

Related Issues

Fixes https://github.com/fluttercommunity/plus_plugins/issues/939#issuecomment-1209368311

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • [ ] All existing and new tests are passing.
  • [x] I updated the version in pubspec.yaml and CHANGELOG.md.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] The analyzer (flutter analyze) does not report any problems on my PR.
  • [ ] I read and followed the Flutter Style Guide.
  • [x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • [ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • [ ] No, this is not a breaking change.

nohli avatar Aug 09 '22 14:08 nohli

Since we already had a breaking change for removing the getter, and this PR is fixing bugs where the androidId is null, it probably is not a breaking change?

nohli avatar Aug 09 '22 14:08 nohli

Yep, I agree with that! Any thoughts on this @vbuberen before we merge?

miquelbeltran avatar Aug 09 '22 15:08 miquelbeltran

@miquelbeltran I updated the changelog to link the new android_id package (could be handy for users checking why it got removed). It already has a popularity of 70% and so far no reported issues, so should be safe to migrate.

Would say let's merge this and publish it along with all the other plus packages that have new versions on main, what do you think 🙂

nohli avatar Aug 10 '22 21:08 nohli