flutter_downloader
flutter_downloader copied to clipboard
fluttercommunity
Add text column db
in my use case I have to add additional info to task table (very necessary for me). refer to issue #195 so I open my first pull request in open source. then I try to download but it will fail. if anyone can help me that's a good encouragement for me.
Thanks to the community.
Have you tested on iOS yet? On the iOS side, to modify the database schema, you need to update the sql file too. And what about DB migration? If current projects upgrade to this new DB, does it still work?
Hi hnvn. No, I don't test it on ios. So what do we should do?
I think this is necessary in most projects which uses flutter downloader.
Working with SQLite in iOS is painful. I concern that modifying DB schema might break the current features.
Ok, Thanks a lot hnvn for attention. If you decide to modify DB, I will test it on both ios and Android to see does it break current features or not. But if you can't, I hope someone can modify the DB.
Thanks for your contribution. My priority now is to migrate this plugin to embedding v2, then I will get back to this issue and try to find a solution for it.
Thanks for your plugin migration. Is it possible to find a solution for this?
@mohammadne Do you use this to store json data? I'm looking for something that could do that instead of writing it externally and keeping two separate date sources in sync.
If you need to store additional information related to a task (and that information is not related to downloading the task) then I think you should create an additional database or map that has taskId as its key and whatever fields you want to add. I don't think you should add functionality or features to the downloader task database that are not strictly required for or related to the download functionality
Hi,
I think the better idea is to define a list of parameters like Map<String,String> and before storing in database use method like "json_encode" to convert that list to string, and when retrieving from database convert it back to list by "json_decode". Also, maybe we can also use an extra column like 'description' column in tasks database for this purpose. Adding description column to database is common in programming and can be used for different goals like this.
I'm looking forward to hearing from you guys. Thanks.
Hey @hnvn, what must be done so this PR gets merged? I also need it and it seems that most of the job is done here, isn't it?
I am willing to contribute if I can.
Working with SQLite in iOS is painful. I concern that modifying DB schema might break the current features.
What are you afraid of @hnvn? Since this is a new column I don't see how it could break any feature as no pre-existing code rely on it.
I see that at the moment the plugin simply deletes the previous database in Android when a migration of the database is required (TaskDbHelper.onUpgrade), couldn't the same be done on iOS? (Although it's quite rude... it would be rather simple to only alter the table upon migration on Android, on iOS I don't know, it seems to be less automatic).
Hi, is this a tested fork, does it work on both android and ios, if it does it should be merged with the main project, it a very crucial features, how are we supposes to track what our apps download if there is noting unique we can add in the tasks db, so pls @hnvn can you inform us if we should use this fork or if we should wait till it can be merged.
Alas it seems that nothing has happen on this matter. I have had to implement my own persistent db in parallel to keep track of the "loading task"/"app entity" mapping and it has been a real pain to keep it in sync with the plugin's one. If someone could finish this PR all this work could be avoided (I didn't because I am not myself an iOS developer).
I had created another issue where I describe the problems that such a feature would solve: #402.