flutter_downloader icon indicating copy to clipboard operation
flutter_downloader copied to clipboard

Published 20 hours ago • verified publisher icon fluttercommunity

fix: remove networktype requirement

Open yuxizhe opened this issue 5 years ago • 1 comments

maybe fix: #129

But I don't think its a good solution... 🤔

yuxizhe avatar Sep 25 '19 06:09 yuxizhe

Have you tried to discuss your matter in WorkManager repository yet? I think you can have a better solution from there.

hnvn avatar Sep 25 '19 06:09 hnvn

Yeah, try submitting a bug report at Google Issue Tracker for WorkManager library. This is a problem at the platform level. I'm hesitant about implementing a workaround for this in the package itself.

bartekpacia avatar Aug 21 '22 20:08 bartekpacia

What if we made it available to the developer to change the requiredNetworkType with proper explanations referring the #129, so that this package could still be used, just on developer's own responsibility?

Albert221 avatar Sep 28 '22 22:09 Albert221

@Albert221 That'd be another flag which is always present but has effect only on Android. As an escape hatch – okay, but we already have many such escape hatches. That said, I think you convinced me - there're many Flutter devs in China mainland who should be able to use this plugin without forking. I'm open to a PR.

I'm thinking about creating per-platform classes (like the flutter_local_notifications package does). So we'd have AndroidFlutterDownloaderPlugin and IOSFlutterDownloaderPlugin, and they'd implement the platform-specific options.

bartekpacia avatar Sep 28 '22 22:09 bartekpacia