chewie icon indicating copy to clipboard operation
chewie copied to clipboard

Add swipedown exit fullscreen feature

Open Ortes opened this issue 3 months ago • 2 comments

Ortes avatar Sep 19 '25 19:09 Ortes

Codecov Report

:x: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 43.60%. Comparing base (d228479) to head (0974735). :warning: Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/src/chewie_player.dart 0.00% 10 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
- Coverage   43.84%   43.60%   -0.25%     
==========================================
  Files          21       21              
  Lines        1601     1610       +9     
==========================================
  Hits          702      702              
- Misses        899      908       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Sep 19 '25 19:09 codecov[bot]

Two things:

  1. You need to make this configurable from the ChewieConttoller. In other words, you need to make this opt-in.
  2. When making this configurable, you also need to make the threshold dismissing on swipe a configurable value, defaulting to a reasonable value.

diegotori avatar Sep 20 '25 03:09 diegotori