chewie icon indicating copy to clipboard operation
chewie copied to clipboard

Upgrade to Flutter 3.10

Open cyberpwnn opened this issue 1 year ago • 6 comments

../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/chewie-1.0.0/lib/src/chewie_player.dart:144:18: Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.
    SystemChrome.setEnabledSystemUIOverlays(
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/chewie-1.0.0/lib/src/chewie_player.dart:157:20: Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.
      SystemChrome.setEnabledSystemUIOverlays(
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/chewie-1.0.0/lib/src/chewie_player.dart:161:20: Error: Member not found: 'SystemChrome.setEnabledSystemUIOverlays'.
      SystemChrome.setEnabledSystemUIOverlays([]);
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/chewie-1.0.0/lib/src/material_controls.dart:441:50: Error: The getter 'accentColor' isn't defined for the class 'ThemeData'.
 - 'ThemeData' is from 'package:flutter/src/material/theme_data.dart' ('../../../flutter/packages/flutter/lib/src/material/theme_data.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'accentColor'.
                  playedColor: Theme.of(context).accentColor,
                                                 ^^^^^^^^^^^
../../../../../AppData/Local/Pub/Cache/hosted/pub.dev/chewie-1.0.0/lib/src/material_controls.dart:442:50: Error: The getter 'accentColor' isn't defined for the class 'ThemeData'.
 - 'ThemeData' is from 'package:flutter/src/material/theme_data.dart' ('../../../flutter/packages/flutter/lib/src/material/theme_data.dart').
Try correcting the name to the name of an existing getter, or defining a getter or field named 'accentColor'.
                  handleColor: Theme.of(context).accentColor,
                                                 ^^^^^^^^^^^

cyberpwnn avatar May 11 '23 18:05 cyberpwnn

@cyberpwnn the latest version (1.4.0) doesn't use the removed colors or those removed methods. We ensure that the codebase doesn't use any deprecated methods, and if 3.10 introduced them, we migrate them ASAP.

Please upgrade to that, since those lines in question have been upgraded to the latest replacements.

diegotori avatar May 11 '23 18:05 diegotori

image

This issue is related to wakelock. Only chewie 1.0.0 is supported. Wakelock package people are not upgrading to latest version. because of that this issue is coming.

ps6067966 avatar May 13 '23 17:05 ps6067966

Until the packages are updated i've made my fork with wakelock using new win23 version to support flutter 3.10:

  chewie:
    git:
      url: https://github.com/mdeimert/chewie.git
      ref: master

mdeimert avatar May 15 '23 09:05 mdeimert

if we downgrade share_plus and device_info_plus, then also it is workinig fine with 3.10.0

ps6067966 avatar May 15 '23 09:05 ps6067966

@mdeimert this hack might also work (since wakelock doesn't touch any recent additions to the win32 library):

dependency_overrides:
  win32: ^4.0.0

diegotori avatar May 15 '23 15:05 diegotori

@cyberpwnn we managed to release 1.6.0 today, which migrated wakelock to wakelock_plus. As a result, the latter is now fully maintained by Flutter Community, thus ensuring its preservation the immediate and long term future.

diegotori avatar Jul 02 '23 21:07 diegotori