chewie icon indicating copy to clipboard operation
chewie copied to clipboard

Adding Seek buttons for Android

Open GyanendroKh opened this issue 2 years ago • 3 comments

Adding Forward and Backward seek buttons for Android. Fixes #615

GyanendroKh avatar Jan 28 '23 07:01 GyanendroKh

If you can accomplish this for CupertinoControls, then I would accept this PR.

@brianegan any thoughts on this proposed change, since that would be nice if users were able to seek.

diegotori avatar Jan 30 '23 23:01 diegotori

If you can accomplish this for CupertinoControls, then I would accept this PR.

@brianegan any thoughts on this proposed change, since that would be nice if users were able to seek.

CupertinoControls already have seek buttons on the bottom bar.

https://github.com/fluttercommunity/chewie/blob/master/lib/src/cupertino/cupertino_controls.dart#L277-L279

Isn't this the one that you are referring to

GyanendroKh avatar Jan 31 '23 13:01 GyanendroKh

Please merge this PR, because Android need this feature

andes2912 avatar May 17 '24 12:05 andes2912

Please merge this PR, because Android need this feature

We can't merge changes without investigating and the changes are done which @diegotori requested. Please update your PR accordingly and we will test this :)

Ahmadre avatar Sep 03 '24 23:09 Ahmadre

@Ahmadre if you have capacity, please review his changes by running them locally.

I wanna say that there were exceptions thrown due to the current library calling setState while in the middle of one.

Thanks.

diegotori avatar Sep 03 '24 23:09 diegotori

LGTM @diegotori

Your change requests seems to be implemented. We can merge this if you want.

Ahmadre avatar Sep 10 '24 10:09 Ahmadre

@Ahmadre can you please submit a follow-up PR that fixes lint issues related to this one? Thanks.

diegotori avatar Sep 10 '24 12:09 diegotori

@Ahmadre nevermind, managed to nip it when publishing 1.8.5.

diegotori avatar Sep 10 '24 15:09 diegotori