chewie icon indicating copy to clipboard operation
chewie copied to clipboard

Published 20 hours ago • verified publisher icon fluttercommunity

Changed the mode of CircularProgressIndicator to adaptive

Open danger-ahead opened this issue 2 years ago • 7 comments

fixes #680

danger-ahead avatar Nov 04 '22 06:11 danger-ahead

LGTM. Will have to run your changes locally before I merge.

diegotori avatar Nov 04 '22 14:11 diegotori

LGTM. Will have to run your changes locally before I merge.

Thanks!

danger-ahead avatar Nov 04 '22 14:11 danger-ahead

LGTM

binSaed avatar Nov 05 '22 18:11 binSaed

@binSaed @diegotori is this PR ready to merge?

danger-ahead avatar Nov 22 '22 14:11 danger-ahead

@binSaed @diegotori is this PR ready to merge?

I'll review it in the next couple of days, or this weekend.

diegotori avatar Nov 23 '22 20:11 diegotori

@danger-ahead quick question. How does CircularProgressIndicator.adaptive() handle it's color on iOS when uses the Cupertino one?

In other words, documentation might be necessary for CupertinoControls in order to properly theme that value, or at least briefly explain what a user might do to change the indicator color on iOS.

Long story short, that adaptive version ignores valueColor and friends on iOS.

diegotori avatar Nov 25 '22 18:11 diegotori

@danger-ahead quick question. How does CircularProgressIndicator.adaptive() handle it's color on iOS when uses the Cupertino one?

In other words, documentation might be necessary for CupertinoControls in order to properly theme that value, or at least briefly explain what a user might do to change the indicator color on iOS.

Long story short, that adaptive version ignores valueColor and friends on iOS.

On iOS, there is only one color and you can update it with background color.

CircularProgressIndicator.adaptive(
    backgroundColor: Colors.red,
  ),

hamishjohnson avatar May 26 '23 05:05 hamishjohnson