chewie icon indicating copy to clipboard operation
chewie copied to clipboard

Is it possible to disable the subtitles by default?

Open JThorvid opened this issue 3 years ago • 2 comments

I've added subtitles and they work. I can disable them in the app manually, but is there a way to disable them in the code automatically (ideally as the default option)?

JThorvid avatar Jun 17 '22 18:06 JThorvid

I would like to work on this issue

PranavMasekar avatar Jan 23 '23 04:01 PranavMasekar

I have implemented this in #865

stevsimo avatar Oct 21 '24 15:10 stevsimo

Hi everyone,

I’d like to provide some context regarding my PR (#872) and how it addresses this issue. The goal here was to ensure subtitles can be disabled by default while maintaining the native Chewie experience, including the use of the subtitle toggle button.

@stevsimo PR (#865) is a great start, but it takes a different approach by disabling subtitles entirely. This means subtitles can no longer be toggled dynamically using the built-in controls, and any control over subtitles would have to be implemented externally. While this might work in specific use cases, it diverges from the native functionality Chewie is designed to provide.

In contrast, my PR introduces a showSubtitles flag:

Subtitles are off by default when the flag is set to false (the default value). Users can still dynamically toggle subtitles during playback using the subtitle toggle button, preserving the seamless native experience. This approach ensures we meet the original request for a default "off" state for subtitles without removing Chewie's built-in functionality. Additionally, I updated the example video URLs as the current ones were no longer accessible. The new URLs ensure the examples function correctly and provide a better demonstration of the feature.

I’d be happy to discuss this further if there’s additional feedback or suggestions. Looking forward to hearing your thoughts!

floodoo avatar Nov 20 '24 18:11 floodoo