chewie icon indicating copy to clipboard operation
chewie copied to clipboard

pop wrong page

Open aslamibnabdulla opened this issue 3 years ago • 6 comments

when pressed on speed controls in bottomsheet it pops the main page and keeps the bottomsheet (not fullscreen mode).same problem additional options . video source cannot be changed in fullscreen mode.

aslamibnabdulla avatar Mar 08 '22 18:03 aslamibnabdulla

Experiencing this same issue too

graphicbeacon avatar Mar 15 '22 10:03 graphicbeacon

@aslamibnabdulla or @graphicbeacon can you please create a reproducible example project so that I can further diagnose this issue? Thanks in advance.

diegotori avatar Mar 15 '22 15:03 diegotori

Same issue here. I'm using Routemaster to handle navigation. Not able to replicate without Routemaster package or Navigator 2.0. To replicate just copy the simple example from routemaster and push a page with Chewie in it. I can create a GitHub project if needed. Also if fullScreenByDefault: true, you need to press the exit fullscreen button twice to actually exit fullscreen.

Edit: You can find an example here

J-Dark avatar Jun 15 '22 16:06 J-Dark

@J-Dark thank you for creating a reproducible example. Hopefully sometime this week, I'll have to take a look.

diegotori avatar Jun 21 '22 22:06 diegotori

@diegotori, any news on this and #647? Also, this doesn't happen on iOS; only Android and Web.

J-Dark avatar Jul 19 '22 07:07 J-Dark

I'll end up taking a look, possibly this week. @maherjaafar if you also want to take a look, go for it as well.

diegotori avatar Jul 19 '22 14:07 diegotori

Hi! Is there an update on this ? I'm experiencing the same issue on version 1.3.4.

sanchez-gonzalo94 avatar Nov 06 '22 20:11 sanchez-gonzalo94

Hi! Is there an update on this ? the same issue on version 1.3.6. it pop when open speed control.

hamidwaezi avatar Jan 05 '23 03:01 hamidwaezi

@hamidwaezi I ended up creating custom_controls.dart by coping material_controls.dart and removing the Navigator.pop(context); in _buildOptionsButton(). It's not quite the right behaviour but it's better than popping the main page.

J-Dark avatar Jan 10 '23 11:01 J-Dark

@hamidwaezi I ended up creating custom_controls.dart by coping material_controls.dart and removing the Navigator.pop(context); in _buildOptionsButton(). It's not quite the right behaviour but it's better than popping the main page.

i just remove this line in _buildOptionsButton useRootNavigator: chewieController.useRootNavigator, and it work like a charm

hamidwaezi avatar Mar 03 '23 07:03 hamidwaezi