chewie icon indicating copy to clipboard operation
chewie copied to clipboard

Non dragable progress bar

Open ensarkurrt opened this issue 3 years ago β€’ 7 comments

Hi, i need to non-draggable progress bar feature on player. And Chewie Player too for power :) So i modified this library. I hope you merge that feature. I missed add Feature label. Sorry for that.

ensarkurrt avatar Jun 21 '21 15:06 ensarkurrt

thx. I will run the CI, after it's green, we can merge this πŸ‘πŸΌ

Ahmadre avatar Sep 07 '21 20:09 Ahmadre

thx. I will run the CI, after it's green, we can merge this πŸ‘πŸΌ

it’s red. I will fix errors.

ensarkurrt avatar Sep 07 '21 23:09 ensarkurrt

thx. I will run the CI, after it's green, we can merge this πŸ‘πŸΌ

it’s red. I will fix errors.

Fixed. Can you run CI please ?

ensarkurrt avatar Sep 08 '21 11:09 ensarkurrt

thx. I will run the CI, after it's green, we can merge this πŸ‘πŸΌ

it’s red. I will fix errors.

Fixed. Can you run CI please ?

still failing :/

Ahmadre avatar Sep 10 '21 18:09 Ahmadre

@ensarkurrt looks like there's some conflicts with your changes preventing merging. Please resolve those first so that I can merge it into master. Otherwise, the change LGTM. @maherjaafar what say you regarding this change?

Thanks in advance for this change

diegotori avatar Feb 17 '22 13:02 diegotori

@ensarkurrt also looks like CI was failing. Please ensure that it passes lint and formatting checks. Thanks.

diegotori avatar Feb 17 '22 13:02 diegotori

@diegotori thanks for your reply. I will fix the issues. @maherjaafar okey i will check out.

ensarkurrt avatar Feb 23 '22 15:02 ensarkurrt