chewie icon indicating copy to clipboard operation
chewie copied to clipboard

option to not grey out video

Open ekuleshov opened this issue 4 years ago • 9 comments

When using new MaterialControls the whole video screen is dimmed (greyed out) when video is paused or any interactions are happening.

This makes it really hard to see details on the video frame when video is paused or stepped trough.

Please add an option to disable dimming for the video.

PS: I tried to copy MaterialControls code but wasn't been able to remove this dimming. Suspecting that might be outside of control of the customControls.

ekuleshov avatar Jun 13 '21 20:06 ekuleshov

It is true, the previous controls were super better, now that dimmed color is horrible and I have an error in expanding the video, after it expands it does not return to its original state that is to say in the small container where I put it.

imagen 1 imagen1

actual controls horrible imagen 2 imagen2

Is there a way to return to the previous controls like image 1?

Cheers

CARocha avatar Jun 17 '21 16:06 CARocha

I found it was caused by playernotifier image image 1.The easy way is to use the old version of materialcontrols.(https://github.com/gj2569355373/share) 2.You can also download the Chewie source code for modification.

gj2569355373 avatar Jul 26 '21 08:07 gj2569355373

I found it was caused by playernotifier

image

image

1.The easy way is to use the old version of materialcontrols.(https://github.com/gj2569355373/share)

2.You can also download the Chewie source code for modification.

Thanks, but actually the Provider isn't the "error".

As you mention it's a "design" topic which in the past was introduced to behave like Youtube. But thank you, that you found a missing feature, that if you once tap on the dimmed background, the dimming should disappear. And re-appear if tapped again.

So this behavior should be changed.

I'll do that asap.

Ahmadre avatar Jul 30 '21 02:07 Ahmadre

@Ahmadre could we please have an option to disable this "design" completely, so no dimming will be happening ever.

I can see how that could be nice on a large screen. But on the phone with a limited screen real estate this dimming makes the whole video player experience quite bad.

Another "design" piece is the large play button in the middle of the player, which is covering pretty much the most important part of the video where action is happening (on a small screens up to 2/3 of the whole area), so you can't use player to do a step-through.

ekuleshov avatar Jul 30 '21 03:07 ekuleshov

@Ahmadre could we please have an option to disable this "design" completely, so no dimming will be happening ever.

I can see how that could be nice on a large screen. But on the phone with a limited screen real estate this dimming makes the whole video player experience quite bad.

Another "design" piece is the large play button in the middle of the player, which is covering pretty much the most important part of the video where action is happening (on a small screens up to 2/3 of the whole area), so you can't use player to do a step-through.

sure: I will add an option to that 👌🏼

Ahmadre avatar Jul 30 '21 15:07 Ahmadre

Was the option to turn off the dimming effect implemented as @Ahmadre set out to do?

djsjr avatar Jul 20 '22 18:07 djsjr

@Ahmadre any progress on this?

diegotori avatar Jul 21 '22 15:07 diegotori

Same question here, is there any update?

KatyTao avatar Feb 06 '23 07:02 KatyTao

Bro let us remove the ugly opaque background with a flag please.

jblankenship5 avatar Feb 21 '24 22:02 jblankenship5