chewie icon indicating copy to clipboard operation
chewie copied to clipboard

Full Screen Cupertino View

Open brianegan opened this issue 7 years ago • 7 comments

Need to update the Full Screen Cupertino views when in Portrait mode

brianegan avatar Dec 05 '17 22:12 brianegan

Hello, first of all thanks for this plugin, it makes managing video player much easier! Just want to ask if you have made any progress towards solving this issue?

I have also experienced that on iPhone (iOS 10) the looping value has no effect, video will keep looping anyway, also after clicking the "[ ]" icon and transition to "fullscreen" mode, both under portrait and landscape mode, the video's graphic is lost but sound is still playing.

On Android everything works fine.

Understand you could be very busy -- creating and maintaining so many open source and useful stuff, I may be able to contribute and help if you can provide any pointer to a fix.

anzellai avatar Feb 21 '18 11:02 anzellai

Hey there! Yay, glad it's useful :)

Hah, I am indeed quite busy these days!

If this is functionality you'd like to have, I'd love some help. Otherwise, it might be a month or so before I can find time to add this feature.

Therefore, if it's time sensitive or you just wanna have some fun, contributions would be most welcome!

In addition, I don't actually have an iOS device that I can test this on, so I just do everything through the Android Emulator / on my Android phone and assume it works on iOS (turns out that's a bad assumption :P).

brianegan avatar Feb 21 '18 13:02 brianegan

Thanks for your prompt reply!

I have a Macbook and an iOS device, and I will look at the plugin code and see if I can figure out a fix. Will come back in a few days :-)

anzellai avatar Feb 21 '18 14:02 anzellai

Just to follow up for the issue, after debugging my own app, the problem is actually caused by my own widget layout. When I use the Chewie widget on a new page with an initialised and final video controller (instead of initialising a dynamic controller on event callback within the same page), the problem goes away!

A little aesthetic issue is that the large Play icon does not show on iOS -- but easy workaround by creating a play button underneath the widget.

So issue resolved itself, and thanks again for providing this plugin :-)

anzellai avatar Feb 23 '18 11:02 anzellai

Ah, great! Yah sometimes it can be tricky to make sure you're passing through the right instances of the VideoController.

Glad it worked out, happy this package is useful :)

brianegan avatar Feb 23 '18 12:02 brianegan

@brianegan what do you want to change in portrait mode? I still think a portrait fullscreen mode is quite pointless. I would prefer to automatically rotate to landscape. As there are some apps like Youtube which have the same behaviour on iOS, this could be an option: cupertinoAutoLandscapeOnFullScreen. Not to be confused with an option to autoFullScreenOnLandscape which would switch to FullScreen when you rotate the phone --> https://github.com/brianegan/chewie/issues/15.

cbenhagen avatar Jan 20 '19 16:01 cbenhagen

@diegotori shall we close this issue?

maherjaafar avatar Feb 18 '22 14:02 maherjaafar