flutter_photo_manager icon indicating copy to clipboard operation
flutter_photo_manager copied to clipboard

FEAT: change SizeConstraint ignoreSize defualt to true

Open 6a209 opened this issue 11 months ago • 3 comments

The expression "0 < width < 100000" has the same effect as "ignoreSize = true" but adding these two conditions in SQL might degrade performance somewhat.

6a209 avatar Jan 21 '25 09:01 6a209

Changing the flag would be a breaking change for users who wrote a valid condition but didn't toggled the flag before.

AlexV525 avatar Jan 29 '25 08:01 AlexV525

But it originally felt like there was wrong, the default value theory should be unconditional, which would be more reasonable. However, a condition (0 < width < 100000) was added by default. If I really have an image larger than 100000, wouldn't it fail to be filtered out? I think this is not the expected behavior of the user. But then again, 100000 is really too large, almost non-existent such big images, and if such an image were to be loaded into memory all at once, it would definitely cause outofmemory,

6a209 avatar Feb 04 '25 15:02 6a209

But it originally felt like there was wrong, the default value theory should be unconditional, which would be more reasonable.

If we could convert 100000 to null, that would be more reasonable.

AlexV525 avatar Sep 22 '25 02:09 AlexV525