website icon indicating copy to clipboard operation
website copied to clipboard

After deprecation period, remove this recipe from website

Open Yang-Xijie opened this issue 2 years ago • 7 comments

Page URL

https://docs.flutter.dev/cookbook/effects/photo-filter-carousel/

Page source

https://github.com/flutter/website/tree/main/src/cookbook/effects/photo-filter-carousel.md

Describe the problem

This cookbook has several places to improve:

  • codes and explanation are different from each other, as mentioned in #8202
  • Material widget is unnessary.
  • In _buildShadowGradient, height: itemSize + ... will be better than height: itemSize * 2 + ... because the Scrollable will take less space on the screen. If height: itemSize + ... used, it will be better to modify LinearGradient’s Colors.black to Colors.black87 to make the UI more comfortable.
  • The Ring has the with 6.0 while the FilterItem has padding set to 8.0. It will be better if they are the same.
  • In FilterSelctor, current widget hierarchy is Scrollable > LayoutBuilder > Stack. It will be better to change it to LayoutBuilder > Stack > Scrollable because Scrollable is not related with the Ring and Shadow.
  • IgnorePointer is useless because Scrollable has a higher position (upper in the widget hierarchy) than SelctionRing.

Expected fix

No response

Additional context

No response

Yang-Xijie avatar Feb 03 '23 16:02 Yang-Xijie