website icon indicating copy to clipboard operation
website copied to clipboard

Typo in docs.flutter.dev about Explicit animations

Open broccolism opened this issue 3 years ago • 6 comments

Hello, I've been studying flutter's animation from documentations in flutter.dev. I think I found some typo from the documentation here: https://docs.flutter.dev/codelabs/explicit-animations

image

  1. What does PENDING: # image: a frame in Flutter mean? Since I'm not a native English user, I cannot guess the meaning of this sentence. If it is written in mistake, I think it should be fixed and or not, I wish it was clearer so that everyone reading this documentation can easily understand it.

  2. Even this though example doesn’t use Flutter’s animation library I guess this sentence needs to be: Even though this example doesn’t use Flutter’s animation library

Thanks for nice documentation though!

broccolism avatar Jan 10 '22 12:01 broccolism

@broccolism This issue belongs to flutter website repo. Usually when you access any page, you'll see a bug icon there, clicking on which it'll take you to dedicated repo:

Screenshot 2022-01-11 at 1 22 08 PM

transferring this issue to website.

darshankawar avatar Jan 11 '22 07:01 darshankawar

Hi @broccolism,

Thanks for reporting this.

PENDING: # image: a frame in Flutter

An image is supposed to be shown on that side

Even this though example doesn’t use Flutter’s animation library

Thanks for pointing this out.

Screenshot 2022-01-11 at 12 05 23

The codelab is not yet complete, so bear with us until it is.

danagbemava-nc avatar Jan 11 '22 12:01 danagbemava-nc

@darshankawar @danagbemava-nc Thanks for checking. So I don't need to do anything but closing this issue since this page is still in progress, is it right?

broccolism avatar Jan 13 '22 13:01 broccolism

Let's leave it open, in case the typo was missed

danagbemava-nc avatar Jan 13 '22 13:01 danagbemava-nc

Is codelab completed?

piedcipher avatar Sep 10 '22 20:09 piedcipher

The info section that states that this codelab is not yet complete is still on the page, so I assume it is not complete yet

danagbemava-nc avatar Sep 12 '22 06:09 danagbemava-nc

Thanks for opening the issue and for the discussions!

I'm going to close this in favor of https://github.com/flutter/website/issues/8057 tracking finishing the codelab. Thanks again :)

parlough avatar Jan 06 '23 00:01 parlough