website icon indicating copy to clipboard operation
website copied to clipboard

Refactor 'Deferred components' page to fix one step and to offer Kotlin examples

Open jagomf opened this issue 9 months ago • 2 comments

Page URL

https://docs.flutter.dev/perf/deferred-components/

Page source

https://github.com/flutter/website/tree/main/src/content/perf/deferred-components.md

Describe the problem

  • In Setup -> Step 2 -> Manual setup, the explanation to proceed manually in order to support both SplitCompat and PlayStoreDynamicFeatureManager is missing in all cases the exact path/file where to add the mentioned java/kotlin code.
  • Furthermore, code fragments are Java, when actually most of Android modern code is based on Kotlin. At least both Java and Kotlin code should be provided.

Expected fix

Refactor the mentioned step to provide exact file paths to edit, and provide Java and Kotlin code for all code fragments.

Additional context

No response

I would like to fix this problem.

  • [ ] I will try and fix this problem on docs.flutter.dev.

jagomf avatar Apr 30 '24 15:04 jagomf

@domesticmouse, you're up this week. Any chance of helping with this?

sfshaza2 avatar Apr 30 '24 20:04 sfshaza2

Two problems. First, I don't know kotlin. Second, I'm fully focused on I/O.

@RedBrogdon can you pick another DRE to own this issue?

domesticmouse avatar Apr 30 '24 21:04 domesticmouse