website icon indicating copy to clipboard operation
website copied to clipboard

Update associated domains instructions on 'Set up universal links for iOS' page

Open oodavid opened this issue 1 year ago • 4 comments

Page URL

https://docs.flutter.dev/cookbook/navigation/set-up-universal-links/

Page source

https://github.com/flutter/website/tree/main/src/cookbook/navigation/set-up-universal-links.md

Describe the problem

When using xcode to add the associated-domains only ios/Runner/RunnerRelease.entitlements is updated - when developing, we also need to adjust ios/Runner/Runner.entitlements.

Expected fix

Don't recommend editing these values with xcode, instead recommend directly editing the config files:

  • ios/Runner/Info.plist
  • ios/Runner/RunnerRelease.entitlements

With an additional note to check for other entitlement files for different release modes in the ios/Runner directory.

Additional context

Other pages in the docs recommend editing the config files directly (ie: not via xcode):

https://docs.flutter.dev/data-and-backend/networking#macos https://docs.flutter.dev/platform-integration/ios/ios-app-clip https://docs.flutter.dev/perf/impeller

oodavid avatar Feb 02 '24 09:02 oodavid

Can I work on this and send a PR?

milansurelia avatar May 17 '24 14:05 milansurelia

Sure. I was looking into it, but happy to have the help @milansurelia

atsansone avatar May 20 '24 20:05 atsansone

@atsansone I have updated the site content and attached an image. Could you please verify it?

PR1

PR2

milansurelia avatar May 25 '24 10:05 milansurelia

@atsansone Have you checked the above screenshot? Is it correct?

milansurelia avatar Jun 19 '24 11:06 milansurelia