samples icon indicating copy to clipboard operation
samples copied to clipboard

[veggieseasons] retire VeggieSeasons

Open johnpryan opened this issue 2 years ago • 5 comments

A test in veggieseasons is failing: https://github.com/flutter/samples/actions/runs/5060535147/jobs/9083548830, which seems unrelated to the PR: https://github.com/flutter/samples/pull/1837

/home/runner/work/samples/samples/veggieseasons/test/restoration_test.dart: restoration smoke test (failed)
  ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
  The following TestFailure was thrown running a test:
  Expected: no matching nodes in the widget tree
    Actual: _TextFinder:<exactly one widget with text "In season today" (ignoring offstage widgets):
  Text("In season today", inherit: true, color: label(*color = Color(0xff000000)*, darkColor =
  Color(0xffffffff), resolved by: Builder), family: NotoSans, size: 32.0, weight: 700, style: normal,
  letterSpacing: -0.4, decoration: TextDecoration.none, dependencies: [DefaultSelectionStyle,
  DefaultTextStyle, MediaQuery])>
     Which: means one was found but none were expected
  
  When the exception was thrown, this was the stack:
  #4      main.<anonymous closure> (file:///home/runner/work/samples/samples/veggieseasons/test/restoration_test.dart:34:5)
  <asynchronous suspension>
  <asynchronous suspension>
  (elided one frame from package:stack_trace)
  
  This was caught by the test expectation on the following line:
    file:///home/runner/work/samples/samples/veggieseasons/test/restoration_test.dart line 34
  The test description was:
    restoration smoke test
  ════════════════════════════════════════════════════════════════════════════════════════════════════
  Test failed. See exception logs above.
  The test description was: restoration smoke test

johnpryan avatar May 23 '23 19:05 johnpryan

I can't reproduce locally, the test looks like it's only failing in CI.

johnpryan avatar May 23 '23 20:05 johnpryan

@RedBrogdon do you remember who implemented state restoration for Veggie Seasons? We might need some help with debugging CI.

domesticmouse avatar May 24 '23 14:05 domesticmouse

Looks like the 7.1.0 release of go_router is the cause, but I don't have time to dive into what needs to change currently.

parlough avatar May 24 '23 19:05 parlough

Blocked on https://github.com/flutter/flutter/issues/127518

domesticmouse avatar Aug 02 '23 00:08 domesticmouse