samples icon indicating copy to clipboard operation
samples copied to clipboard

Published 20 hours ago • verified publisher icon flutter

Update `simplistic_editor` for Flutter 3.4 beta

Open bleroux opened this issue 3 years ago • 5 comments

This PR updates simplistic_editor for Flutter 3.4 beta.

Fixes https://github.com/flutter/samples/issues/1443

Pre-launch Checklist

  • [x] I read the [Flutter Style Guide] recently, and have followed its advice.
  • [x] I signed the [CLA].
  • [x] I read the [Contributors Guide].
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] All existing and new tests are passing.

bleroux avatar Sep 27 '22 14:09 bleroux

Please re-enable beta and master CI:

  • https://github.com/NevercodeHQ/samples/blob/Update_simplistic_editor_to_flutter_3.4/tool/flutter_ci_script_beta.sh#L42
  • https://github.com/NevercodeHQ/samples/blob/Update_simplistic_editor_to_flutter_3.4/tool/flutter_ci_script_master.sh#L44

domesticmouse avatar Sep 27 '22 21:09 domesticmouse

LGTM once CI is re-enabled

@domesticmouse Thanks for the review and the tip about re-enabling CI. :+1: As this code fails on stable channel, can you explain me the expected process on flutter/samples for merging this PR? Do we have to wait for the next Flutter stable release before merging?

bleroux avatar Sep 28 '22 11:09 bleroux

LGTM once CI is re-enabled

@domesticmouse Thanks for the review and the tip about re-enabling CI. :+1:

As this code fails on stable channel, can you explain me the expected process on flutter/samples for merging this PR? Do we have to wait for the next Flutter stable release before merging?

Yup, this PR will hang here until we have a new stable. I'll handle rolling this into a beta branch and then into stable.

domesticmouse avatar Sep 28 '22 13:09 domesticmouse

Can you please update this PR, or give me access to do so? It has conflicts =(

domesticmouse avatar Oct 09 '22 10:10 domesticmouse

Can you please update this PR, or give me access to do so? It has conflicts =(

I have updated the PR. FYI, I disabled master channel CI because there is a new breaking change in master and this PR is targeting beta channel.

bleroux avatar Oct 10 '22 07:10 bleroux

Please merge the latest from main. I'm preparing for a beta uber PR that this would be rolled into.

domesticmouse avatar Jan 09 '23 22:01 domesticmouse

Integrated into https://github.com/flutter/samples/pull/1556

domesticmouse avatar Jan 10 '23 04:01 domesticmouse

I have rebased this PR and updated it to comply with https://github.com/flutter/flutter/pull/76072 (add an implementation for TextInputClient.didChangeInputControl). I have also renabled CI on master because beta and master are aligned now.

bleroux avatar Jan 10 '23 09:01 bleroux

@domesticmouse This PR should be ok now on beta and master.

bleroux avatar Jan 10 '23 10:01 bleroux

Thank you, re-integrated into #1556 and now everything is green on beta and master. =)

domesticmouse avatar Jan 10 '23 14:01 domesticmouse

This should now be closeable. To be sure, please resolve conflicts and you should hopefully see this PR resolve to 0 files changed.

domesticmouse avatar Jan 24 '23 23:01 domesticmouse

This should now be closeable. To be sure, please resolve conflicts and you should hopefully see this PR resolve to 0 files changed.

Great! Happy that those changes were useful :+1:

bleroux avatar Jan 25 '23 07:01 bleroux