samples icon indicating copy to clipboard operation
samples copied to clipboard

Add add-to-app sample that uses `flutter build macos-framework`

Open jmagman opened this issue 2 years ago • 10 comments

flutter build macos-framework is available in master, but only works from normal flutter created apps, not -t module. Add a sample that shows flutter build macos-framework and flutter build ios-framework from a normal app (not module)

See https://github.com/flutter/flutter/issues/104866 and https://github.com/flutter/flutter/pull/105242.

jmagman avatar Jun 03 '22 17:06 jmagman

@jmagman Any ideas when this will show up on beta?

domesticmouse avatar Jun 04 '22 01:06 domesticmouse

Not sure what the beta schedule is. I need a few engine changes too, I'll try to get that in next week. I assigned this to myself, I have a prototype working.

jmagman avatar Jun 04 '22 05:06 jmagman

Sounds good. To land a sample that only works in beta will require adding it to the beta CI and adding it commented out to the stable CI. I'm happy to own the AI to enable it with the next stable release.

domesticmouse avatar Jun 04 '22 05:06 domesticmouse

Is the add-to-app sample available? It will be really helpful if you can share it.

bkytes avatar Jan 31 '23 10:01 bkytes

Is the add-to-app sample available? It will be really helpful if you can share it.

Have a look at the code under add_to_app.

domesticmouse avatar Feb 01 '23 00:02 domesticmouse

The request would be to add a macOS sample version under https://github.com/flutter/samples/tree/main/add_to_app/prebuilt_module

jmagman avatar Feb 01 '23 01:02 jmagman

Please add a sample for macOS

bkytes avatar Feb 01 '23 06:02 bkytes

@bkytes that's what this open issue is already tracking.

jmagman avatar Feb 01 '23 20:02 jmagman

Any updates on the add-to-app sample and documentation for macOS?

SharanPadmanabhan avatar Apr 12 '23 05:04 SharanPadmanabhan

No update, but we take pull requests if you want to try adding it 🙂

jmagman avatar Apr 12 '23 18:04 jmagman