plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[various] Update `annotation` in all packages

Open stuartmorgan opened this issue 1 year ago • 3 comments

Updates androidx.annotation to the last version throughout the repository.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

stuartmorgan avatar Sep 09 '22 20:09 stuartmorgan

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Sep 09 '22 20:09 flutter-dashboard[bot]

This seems easier than fixing up all of the dependabot PRs for annotation.

stuartmorgan avatar Sep 09 '22 20:09 stuartmorgan

Hm, looks like this is hitting a resolver conflict with something that requires 1.2.0. I'll have to investigate more.

stuartmorgan avatar Sep 09 '22 20:09 stuartmorgan

@stuartmorgan Is this PR still on your radar?

Hixie avatar Dec 07 '22 00:12 Hixie

No, I think we decided we need to move some gradle versions forward in the template/tool, and/or have better error messages for mismatches, before mass upgrading this.

stuartmorgan avatar Jan 04 '23 01:01 stuartmorgan