[google_maps_flutter_web] Pass BitmapDescriptor.fromBytes size to JS SDK (2/2)

Open ditman opened this issue 3 years ago • 0 comments

Updates conversion of BitmapDescriptor.fromBytes marker icons to support the new size parameter.

Also:

Minor refactor to extract the conversion of BitmapDescriptor to gm.Icon to a separate method.
Updates test mocks to the ones generated by the currently selected version of Mockito (5.3.0)

Blocked by https://github.com/flutter/plugins/pull/6208 (also contained here, this needs to be rebased once 6208 lands)
Fixes https://github.com/flutter/flutter/issues/73789

This will fail several checks (publishable at least?) until the platform_interface PR listed above lands. Feel free to skip the code in the platform_interface package from this PR.

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Aug 05 '22 04:08 ditman

Thanks for taking care of this one @stuartmorgan, I've added the autosubmit label so it lands whenever. 🙏

Aug 17 '22 09:08 ditman