plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[webview_flutter] Expose the allowsLinkPreview property in WKWebView for iOS

Open b099l3 opened this issue 2 years ago • 10 comments

This PR fixes this issue:

  • https://github.com/flutter/flutter/issues/69748
  • (duplicate) https://github.com/flutter/flutter/issues/100783

Exposes the allowsLinkPreview boolean property on WKWebview. To enable or disable link previews.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

b099l3 avatar Mar 26 '22 00:03 b099l3

Hi @b099l3, thanks for the contribution! We're currently working on reworking the plugin interface and converting the platform implementation to mirror the native apis. We have a current halt on new features until these two issues are complete. We'll revisit this PR/issue thereafter.

bparrishMines avatar Apr 05 '22 16:04 bparrishMines

The Dart conversion is complete, and this doesn't change anything problematic in the platform interface, so this is unblocked now. You'll just need to update the implementation for the new Dart version.

stuartmorgan avatar Jul 28 '22 20:07 stuartmorgan

nice I'll take a look this weekend

b099l3 avatar Jul 29 '22 14:07 b099l3

@b099l3 Was this ready for another review? Are you still working on it?

bparrishMines avatar Aug 26 '22 20:08 bparrishMines

Hi sorry still working on it, had to get my head back in the code, looking at it today

b099l3 avatar Sep 02 '22 14:09 b099l3

Fix the dart update and comments but notice the platform has changed for 4.0.0, so making my changes fit the new structure.

b099l3 avatar Sep 02 '22 23:09 b099l3

@bparrishMines I should be ready for a review now. Sorry for the delay I have never used pigeon before and was working out how to generate the files.

I noticed that the version for pigeon was different:

  • web_kit.pigeon.dart & test_web_kit.pigeon.dart are on 3.1.5 and
  • FWFGeneratedWebKitApis.m & FWFGeneratedWebKitApis.h are on 3.2.6 so I went with the higher one

b099l3 avatar Sep 05 '22 21:09 b099l3

Cool think this is good for a review @bparrishMines when you have time

b099l3 avatar Sep 07 '22 17:09 b099l3

@bparrishMines I'm getting some funky test failures but I don't think I have changed that code. I have made the changes from the review

b099l3 avatar Sep 10 '22 12:09 b099l3

The ios-build_all_plugins CHANNEL:stable is failing due to an infra error. It should pass on a rerun. ios-platform_tests CHANNEL:master is failing due to a flake. It should pass on a rerun as well.

bparrishMines avatar Sep 13 '22 19:09 bparrishMines

This will need to be updated for the restructuring in webview_flutter v4; once that's done we can re-review. Apologies that this fell through the cracks on secondary review while the v4 changes were happening, but we can make sure to review faster once it's updated.

stuartmorgan avatar Jan 11 '23 19:01 stuartmorgan

I'm going to go ahead and mark this as a draft since it needs to be reworked for v4, just to get it off of our review queue. Please mark it as ready for review once that's been done. Thanks!

stuartmorgan avatar Feb 09 '23 20:02 stuartmorgan

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

stuartmorgan avatar Feb 22 '23 15:02 stuartmorgan