plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[google_maps_flutter_web] Options to disable tilt controls and configure gesture handling

Open Rexios80 opened this issue 2 years ago • 5 comments

tiltControlsEnabled: On web, in satellite view, and at close zoom levels, the map displays tilt controls. This lets you disable them.

gestureHandling: On web, without greedy gesture handling the map can have an overlay saying you can only move the map with two fingers or Cmd+drag. This is not ideal, and greedy gestures lets you make that not happen. I added the other gesture handling options from the Google Maps documentation for completeness.

List which issues are fixed by this PR. You must list at least one issue.

flutter/flutter/#99044

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Rexios80 avatar Feb 24 '22 03:02 Rexios80

I wasn't sure how to depend on the updated google_maps_flutter_platform_interface without depending on it form the path. Is there some fancy way to do that? Or does it need to be published first?

Rexios80 avatar Feb 24 '22 03:02 Rexios80

Oh they're supposed to be separate PRs. I guess I'll do that.

Rexios80 avatar Feb 24 '22 03:02 Rexios80

@ditman ping on this review from triage.

stuartmorgan avatar Apr 19 '22 15:04 stuartmorgan

What's the status here? Is this waiting for another update, or for another round of review?

stuartmorgan avatar Aug 16 '22 16:08 stuartmorgan

This PR is waiting for another round of review

Rexios80 avatar Aug 16 '22 17:08 Rexios80

@ditman Ping on this re-review (from triage).

stuartmorgan avatar Oct 13 '22 20:10 stuartmorgan

@ditman Just a friendly reminder this is ready for another round of review :)

GaryQian avatar Nov 01 '22 17:11 GaryQian

I'll get this reviewed (and maybe the branch updated) on Friday, November 4th. Apologies for the delay, I got busy with a couple of other super high priority issues :(

ditman avatar Nov 01 '22 17:11 ditman

@ditman Ping from triage; looks like this fell through the review cracks again.

stuartmorgan avatar Jan 17 '23 19:01 stuartmorgan

Update from triage: this is waiting for @ditman to have bandwith to review maps PRs.

stuartmorgan avatar Feb 14 '23 21:02 stuartmorgan

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

stuartmorgan avatar Feb 22 '23 15:02 stuartmorgan