plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[google_maps_flutter] Add Groundoverlay support for Android

Open UDAYBIDKAR opened this issue 4 years ago • 7 comments

Adds APIs to support adding GroundOverlay to the MapView.

This PR adds a feature to Android to begin with, iOS implementation will follow.

Issues https://github.com/flutter/flutter/issues/26479

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • [x] I updated CHANGELOG.md to add a description of the change.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

UDAYBIDKAR avatar Oct 01 '21 22:10 UDAYBIDKAR

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Oct 01 '21 22:10 google-cla[bot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Oct 01 '21 22:10 google-cla[bot]

@googlebot I signed it!

On Fri, Oct 1, 2021 at 3:26 PM google-cla[bot] @.***> wrote:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA Individual signers

Corporate signers

ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fflutter%2Fplugins%2Fpull%2F4410 for more info.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flutter/plugins/pull/4410#issuecomment-932612359, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVCGO6L23PZMHTZDJ2SYZDUEYYR7ANCNFSM5FFSL76A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

UDAYBIDKAR avatar Oct 04 '21 15:10 UDAYBIDKAR

@tuemaytinh1981 Please stop spamming maps PRs with this off-topic question.

stuartmorgan-g avatar Nov 05 '21 14:11 stuartmorgan-g

Marking as a draft since this isn't fully review-ready yet.

stuartmorgan-g avatar Feb 08 '22 16:02 stuartmorgan-g

@UDAYBIDKAR Thanks for your contribution so far; are you interested in addressing the code review comments above so that we can take this PR all the way to landing?

Hixie avatar Apr 05 '22 23:04 Hixie

Looks like @UDAYBIDKAR is unfortunately no longer around to work on this, but if anyone else would like to take this PR and run with it, please don't hesitate to step up. It looks like it's close, there's just code review comments to address.

Hixie avatar Jun 07 '22 23:06 Hixie

Since this doesn't have an active owner, I'm going to go ahead and close it. If anyone is interested in moving forward with implementing this feature, forking this PR would be a good starting point.

stuartmorgan-g avatar Aug 30 '22 14:08 stuartmorgan-g