pinball icon indicating copy to clipboard operation
pinball copied to clipboard

Added Portuguese transalations

Open Santos-Enoque opened this issue 3 years ago โ€ข 4 comments

Description

I have added an .arb translation file for Portuguese translations

Type of Change

  • [ x] โœจ New feature (non-breaking change which adds functionality)
  • [ ] ๐Ÿ› ๏ธ Bug fix (non-breaking change which fixes an issue)
  • [ ] โŒ Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] ๐Ÿงน Code refactor
  • [ ] โœ… Build configuration change
  • [ ] ๐Ÿ“ Documentation
  • [ ] ๐Ÿ—‘๏ธ Chore

Santos-Enoque avatar May 11 '22 09:05 Santos-Enoque

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 11 '22 09:05 google-cla[bot]

Thanks for the contribution @Santos-Enoque! Would you be able to provide a short screen recording or screenshots of the translations running in the application? Some of these strings are shown in Flame instead of Flutter so the auto scaling isn't always 100%. Just want to make sure we don't have any overlapping or clipping.

tomarra avatar May 12 '22 22:05 tomarra

@Santos-Enoque thanks for your contribution. @tomarra can you take a look and decide what should be done with this PR?

Hixie avatar Jul 27 '22 17:07 Hixie

Left one small suggestions, other than that, LGTM.

CI needs to be solved though, spell checker is failing due to the addition of the Portuguese words, Ideally would be nice to add a pt spell checker for this file, but AFAIK the spell check action only supports us and gb english, so maybe we could just ignore the portugue arb file on the step.

erickzanardo avatar Jul 28 '22 13:07 erickzanardo

Left one small suggestions, other than that, LGTM.

CI needs to be solved though, spell checker is failing due to the addition of the Portuguese words, Ideally would be nice to add a pt spell checker for this file, but AFAIK the spell check action only supports us and gb english, so maybe we could just ignore the portugue arb file on the step.

Is there something I should do to take care of the spell_check?

Santos-Enoque avatar Aug 15 '22 16:08 Santos-Enoque

Thanks for your contribution and sorry for making you jump through so many hoops given what I'm about to say... We've actually decided to archive this repo since we don't have anyone working on it full time these days, since it was mostly a demo for an event, but please don't hesitate to fork the repo (it's open source!) if you want to keep it alive!

Hixie avatar Aug 18 '22 17:08 Hixie