packages icon indicating copy to clipboard operation
packages copied to clipboard

[various] Use RadioGroup for groupValue and onChanged

Open Phantom-101 opened this issue 6 months ago • 2 comments

Use RadioGroup to avoid deprecated groupValue and onChanged (flutter/flutter#170915)

Pre-Review Checklist

Phantom-101 avatar Jun 20 '25 21:06 Phantom-101

It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

flutter-dashboard[bot] avatar Jun 20 '25 21:06 flutter-dashboard[bot]

Thanks for the contribution! Marking as a draft for now since this will require min SDK updates, and that can't be done in the PR until the next stable has shipped.

stuartmorgan-g avatar Jun 24 '25 18:06 stuartmorgan-g

It should be possible to update this to be landable now that 3.35 has shipped to stable.

stuartmorgan-g avatar Aug 19 '25 18:08 stuartmorgan-g

From triage: @Phantom-101 Are you still planning on updating this PR to resolve the CI failures?

stuartmorgan-g avatar Sep 23 '25 18:09 stuartmorgan-g

Sorry for the delay, I am currently busy with some other work so it may be a while before I update this.

Phantom-101 avatar Sep 24 '25 21:09 Phantom-101

Hey @Phantom-101 we came across this in triage. I really appreciate your work here, and totally understand your last comment about not being able to return to it right away. Since this has many merge conflicts now I am going to close it. Please do feel free to open a fresh PR if you decide to come back to this work. Thank you!

Piinks avatar Nov 11 '25 23:11 Piinks