[ci] Remove in_app_purchase_storekit from Xcode analyzer exclusion list

[jmagman]

StoreKit2 is now the default and https://github.com/flutter/flutter/issues/116383 is closed. Let's remove it from the deprecation exclusion list to ensure we get new deprecation warnings.

Pre-Review Checklist

• [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
• [x] I read the Tree Hygiene page, which explains my responsibilities.
• [x] I read and followed the relevant style guides and ran the auto-formatter.
• [x] I signed the CLA.
• [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• [x] I linked to at least one issue that this PR fixes in the description above.
• [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1].
• [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1].
• [x] I updated/added any relevant documentation (doc comments with ///).
• [x] I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under[^1].
• [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.