packages
packages copied to clipboard
[webview_benchmarks] Migrate to null safety
Migrated package to null safety
List which issues are fixed by this PR. You must list at least one issue. Fixes: #98647
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format
.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences]
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.md
to add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///
). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
@yjbanov / @stuartmorgan . this is ready to be reviewed. Thanks.
@stuartmorgan should I also update dependencies in pubspec.yaml? Since the versions used were to support non-null safe code with +2 to allow null safe.
@stuartmorgan should I also update dependencies in pubspec.yaml? Since the versions used were to support non-null safe code with +2 to allow null safe.
Yes, a null-safe package should require null-safe dependencies.
@yjbanov should do the primary review on this.
@yjbanov Ping on this review?
@mdebbar I have done the changes.